Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39907: Added symbolic definitions for known HTTP status codes in qhttp #795

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

iagaponenko
Copy link
Contributor

Also migrated clients of the module to use these definitions instead of numeric literals ("magic" constants).

Also migrated clients of the module to use these definitions
instead of numeric literals ("magic" constants).
Copy link
Contributor

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@iagaponenko iagaponenko merged commit 4736389 into main Jul 6, 2023
10 of 11 checks passed
@iagaponenko iagaponenko deleted the tickets/DM-39907 branch July 6, 2023 04:13
@iagaponenko iagaponenko changed the title Added symbolic definitions for known HTTP status codes in qhttp DM-39907: Added symbolic definitions for known HTTP status codes in qhttp Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants