DM-39819: Early termination of the large-result queries at Qserv workers #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgates108
approved these changes
Jul 21, 2023
The service is now implemented as a singleton which is initialized and loaded with the configuration parameters at a time when Czar is being created. The rest of the Czar fetches values of the parameters from the singleton. The refactoring aims at reducing the number of parameters sent around in the code and to improve readability of the code.
Note that the enforcement only applies to the file-based result delivery protocol as this mechanism makes no sense when results are streamed to Czar over the SSI protocol. The large result conditions are reported to Czar with the code util::ErrorCode::WORKER_RESULT_TOO_LARGE which would help Czar to identify this specific condition and properly report the one to a user.
The new code verifies if the summary messages reported for the file-based results don't have any error contexts. Abort result merging should any such contexts be found.
Also, added a logging statement on failures to do so.
iagaponenko
force-pushed
the
tickets/DM-39819
branch
from
f8f8dbb
to
044b146
Compare
iagaponenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.