Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42681: Fixed a race condition in qhttp response processing #829

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

iagaponenko
Copy link
Contributor

No description provided.

@iagaponenko iagaponenko changed the title Fixed a race condition in qhttp response processing DM-42681: Fixed a race condition in qhttp response processing Jan 26, 2024
Copy link
Contributor

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks! One very minor suggestion.

// were detected. Duplicate transmission requests will be ignored. An error message
// may be logged. The ongoing transmission won't be affected.

bool _startTransmit();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps reverse the sense of this boolean for better comprehensibility? (true usually implies success?)

Thank you for remaining consistent with my quirky comment style :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Fixed. Tested.

@iagaponenko iagaponenko merged commit 6e91abe into main Jan 26, 2024
11 checks passed
@iagaponenko iagaponenko deleted the tickets/DM-42681 branch January 26, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants