DM-46320: Supporting the multipart/form-data format in the Qserv's push-mode ingest protocol #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzm
reviewed
Oct 3, 2024
| } | ||
| }; | ||
| _contentReader( | ||
| [&](httplib::MultipartFormData const& file) -> bool { |
There was a problem hiding this comment.
Do you really want [&] here? Arg is already a const ref (similar question below for pointer and size_t, customarily passed by value)
There was a problem hiding this comment.
The problem is that this lambda calls 3 methods of the current class. So, I would need at least this to make the compiler happy. It also modifies a value of currentFile. It's easier to pass &.
fritzm
approved these changes
Oct 3, 2024
…t body Added a unit test for testing the request body class http::RequestBodyJSON.
Class http::Module was split into two modules: http::BaseModule and a reduced version of http::Module. The new hierarchy is meant to prepare ground for introducing an intermediate base class that will support data streaming (and file uploading requests) in which the request body can't be read at once. The new class will inherit from http::BaseModule.
iagaponenko
force-pushed
the
tickets/DM-46320
branch
from
2838340
to
8ae7c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.