DM-45842: Add the AWS SDK for C++ into the Qserv build container #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzm
reviewed
Oct 3, 2024
| @@ -22,6 +22,18 @@ find_package(pybind11 REQUIRED) | |||
| find_package(Threads REQUIRED) | |||
| find_package(XRootD REQUIRED) | |||
| find_package(httplib REQUIRED) | |||
| find_package(aws-c-auth REQUIRED) | |||
There was a problem hiding this comment.
Are all these needed (because of transitive dependencies for s3?)
fritzm
approved these changes
Oct 3, 2024
iagaponenko
force-pushed
the
tickets/DM-45842
branch
6 times, most recently
from
859630b
to
fb672c2
Compare
Disabled URL validation for libnks to the old/new Confluence, old/new JIRA and SLAC (for SciSQL documentation).
iagaponenko
force-pushed
the
tickets/DM-45842
branch
from
fb672c2
to
2d03d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.