Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/sp 1793 - use "band" instead of "filter" #146

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Jan 6, 2025

Swap "filter" kwargs, variable names, etc to "band". The ModelObservatory is updated to by default will in the "filter" field with the requested "band", so downstream things in MAF do not need updates.

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yoachim yoachim merged commit 7ed6b2d into main Jan 8, 2025
7 checks passed
@rhiannonlynne rhiannonlynne changed the title Tickets/sp 1793 Tickets/sp 1793 - use "band" instead of "filter" Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants