refactor ddf_presched to make config easier. eliminate magic numbers #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoachim
force-pushed
the
tickets/SP-1852
branch
from
38d8da6 to
d0edb8c
Compare
yoachim
force-pushed
the
tickets/SP-1852
branch
from
d0edb8c to
4602c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor DDF schedulign code a bit in an attempt to make it a little easier for others to come in and use it.
optimize_ddf_timesthe only spot where scheduling logic parameters are setddf_slopes(this does make it return results that are not exact matches to previous versions)min_season_lengthkwarg to be in days rather than a unitless fraction.