-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPSIM-1111: feature - Add altitude and azimuth limits to Conditions, along with new basis function + shadow mask #22
Conversation
cc6a146
to
849ab12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a unit test failing because of the new DeprecationWarning.
Please extend the documentation for the AltAzShadowMaskBasisFunction to include information about how it uses the conditions alt/az limits.
aa713c0
to
b146314
Compare
5338c8c
to
89b6428
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 91 91
Lines 9282 9339 +57
=====================================
- Misses 9282 9339 +57 ☔ View full report in Codecov by Sentry. |
Looks good. This is a nice feature to add, especially for testing use. |
Add altitude and azimuth limits to the conditions object. Add new basis function that can grab and interpret the limits, as well as expand the masks in case a survey will be taking observations in the future.