Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSIM-1111: feature - Add altitude and azimuth limits to Conditions, along with new basis function + shadow mask #22

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Jan 13, 2024

Add altitude and azimuth limits to the conditions object. Add new basis function that can grab and interpret the limits, as well as expand the masks in case a survey will be taking observations in the future.

@yoachim yoachim requested a review from rhiannonlynne January 13, 2024 00:29
@yoachim yoachim force-pushed the tickets/OPSIM-1111 branch from cc6a146 to 849ab12 Compare January 18, 2024 22:11
Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a unit test failing because of the new DeprecationWarning.
Please extend the documentation for the AltAzShadowMaskBasisFunction to include information about how it uses the conditions alt/az limits.

@yoachim yoachim force-pushed the tickets/OPSIM-1111 branch 2 times, most recently from aa713c0 to b146314 Compare January 19, 2024 21:58
@yoachim yoachim force-pushed the tickets/OPSIM-1111 branch from 5338c8c to 89b6428 Compare January 22, 2024 23:36
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (5e03647) 0.00% compared to head (89b6428) 0.00%.

Files Patch % Lines
...uler/scheduler/basis_functions/mask_basis_funcs.py 0.00% 30 Missing ⚠️
...in_scheduler/scheduler/surveys/scripted_surveys.py 0.00% 12 Missing ⚠️
rubin_scheduler/scheduler/features/conditions.py 0.00% 7 Missing ⚠️
...heduler/scheduler/model_observatory/kinem_model.py 0.00% 6 Missing ⚠️
...r/scheduler/model_observatory/model_observatory.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #22   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         91      91           
  Lines       9282    9339   +57     
=====================================
- Misses      9282    9339   +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhiannonlynne
Copy link
Member

Looks good. This is a nice feature to add, especially for testing use.

@yoachim yoachim merged commit fad69f1 into main Jan 23, 2024
8 of 9 checks passed
@rhiannonlynne rhiannonlynne changed the title Tickets/opsim 1111 OPSIM-1111: feature - Add altitude and azimuth limits to Conditions, along with new basis function + shadow mask Jan 24, 2024
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1111 branch May 15, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants