Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/PREOPS-4775: Document the prototype sim archive #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ehneilsen
Copy link
Contributor

No description provided.

@rhiannonlynne
Copy link
Member

Looks fine. I don't understand why you're using
SchemaConverter.opsim2obs
followed immediately by
SchemaConverter.obs2opsim
on the same data though.
(wouldn't it work with a pd.read_sql command? or are you trying to make sure we're agnostic to datatype of the opsim database, and if so, should we add a command in rubin_scheduler to read an opsim database from disk? )

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in conversation though.

@ehneilsen
Copy link
Contributor Author

... wouldn't it work with a pd.read_sql command? or are you trying to make sure we're agnostic to datatype of the opsim database, and if so, should we add a command in rubin_scheduler to read an opsim database from disk?

In part I was trying to make it db format agnostic, and in part to make it robust to what SchemaConverter considers the "opsim" format: the way I did it, either could change, and if SchemaConverter were appropriately updated, then the change would propagate here.

Adding a command in rubin_scheduler from disk would, indeed, simplify this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants