Skip to content

DM-47738: Add deblend_depth to object table #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fred3m
Copy link
Contributor

@fred3m fred3m commented Feb 6, 2025

Checklist

When making changes to YAML files in the schemas directory:

  • If applicable, incremented the schema version number, following the guidelines in the contribution guide
  • Referred to the documentation on specific schemas for additional versioning information, change constraints, or tasks that may need to be performed, based on which schema is being updated

- name: deblend_depth
"@id": "#Object.deblend_depth"
datatype: int
description: Depth of a source in the hieratchy of parents.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hierarchy

@JeremyMcCormick
Copy link
Collaborator

JeremyMcCormick commented Mar 6, 2025

This will need to be rebased with conflicts resolved. Schema files were moved into the python/lsst/sdm/tools directory.

@gpdf
Copy link
Collaborator

gpdf commented May 5, 2025

I'm assuming this was originally intended for inclusion in DP1?

From what I understand, it's now too late for that. What are the prospects for this PR now? The change requested above was just for a typo in the description.

@fred3m
Copy link
Contributor Author

fred3m commented May 5, 2025

@gpdf this will go in with the full DM-47738 PR. Hierarchical deblending is introduced in scarlet lite in this ticket, so it is an irrelevant field for DP1. But this should be ready for merge soon, dependent mostly on how many emergent issues I work on over the next week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants