add linux.percpu api #213
Open
add linux.percpu api #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lneto
reviewed
Dec 17, 2024
| stop(env.threads, script) | ||
| end) | ||
| rcu.map(env.runtimes, function (name) | ||
| stop(env.runtimes, name) |
There was a problem hiding this comment.
why don't we need to stop percpu here as well?
lneto
reviewed
Dec 17, 2024
| function runner.percpu(script, ...) | ||
| local script = trim(script) | ||
| local runtimes = {} | ||
| local args = {...} |
There was a problem hiding this comment.
we don't need this, right? couldn't we just pass ... along?
lneto
reviewed
Dec 17, 2024
| function runner.run(script, ...) | ||
| local script = trim(script) | ||
| if env.runtimes[script] then | ||
| local function runtime_name(script, cpu) |
There was a problem hiding this comment.
I found it a bit misnomer.. not sure if it would be cleaner to use script .. ":" .. cpu directly in place..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.