Fix enum setting used as requirement #15760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked because "auto" resulted in
is_yes
returning false, sotouch_controls = auto
fulfilled thetouch_controls = false
requirement, but that's not something we should rely on.keyboard_mouse
andtouchscreen
are the proper "special" requirements that should be used instead of directly using thetouch_controls
setting as a requirement.How to test
touch_controls = auto
: "Controls" button shown in settingstouch_controls = false
: "Controls" button shown in settingstouch_controls = true
: "Controls" button hidden in settingsThere must be no warnings.