Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum setting used as requirement #15760

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

grorp
Copy link
Member

@grorp grorp commented Feb 5, 2025

This worked because "auto" resulted in is_yes returning false, so touch_controls = auto fulfilled the touch_controls = false requirement, but that's not something we should rely on.

keyboard_mouse and touchscreen are the proper "special" requirements that should be used instead of directly using the touch_controls setting as a requirement.

How to test

touch_controls = auto: "Controls" button shown in settings
touch_controls = false: "Controls" button shown in settings
touch_controls = true: "Controls" button hidden in settings

There must be no warnings.

@grorp grorp added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug @ Mainmenu Code quality labels Feb 5, 2025
Copy link
Collaborator

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfan5 sfan5 added this to the 5.11.0 milestone Feb 5, 2025
@appgurueu appgurueu merged commit 2fb9e4d into luanti-org:master Feb 6, 2025
5 checks passed
@grorp grorp deleted the fox branch February 6, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug Code quality @ Mainmenu One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants