Use frozen_string_literal in class Command #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allan-pires
commented
May 16, 2024
| @@ -228,7 +229,7 @@ def exec! | |||
| # exceeds the amount specified by the max argument. | |||
| def read_and_write(input, stdin, stdout, stderr, timeout=nil, max=nil) | |||
| max = nil if max && max <= 0 | |||
| @out, @err = '', '' | |||
| @out, @err = +'', +'' | |||
There was a problem hiding this comment.
+@: Returns a string that is not frozen: self, if not frozen; self.dup otherwise.
https://ruby-doc.org/3.2.2/String.html#class-String-label-Methods+for+a+Frozen-2FUnfrozen+String
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
frozen_string_literal: truemagic comment to enable frozen string literals onProgeny::Command.Also uses
+''to create mutable strings for@outand@err.Context
There was a deprecation warning for chilled strings merged recently in Ruby: ruby/ruby@12be40a
And with that we started to see the following warnings on progeny: