Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version output to CLI #1352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ketasaja
Copy link
Contributor

Closes #1342.

@@ -1,6 +1,8 @@
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
#pragma once

#define LUAU_VERSION "Luau 0.636"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the idea of just having a hardcoded version string like this, particularly because it means that we'll have to manually update this string every time.

I think the "right" way to do this might be something like... resolving the version by finding the most recent git release tag at build-time, which is kind of awful in-and-of-itself. Similarly, it would be nice to include the slug for the git hash in the release string as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @andyfriesen do you have some thoughts on a good way to do this beyond hard-coding the version string?

Copy link
Contributor

@alexmccord alexmccord Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only there was a tool that we ran each time we sync code that we could modify to handle this.

Copy link
Collaborator

@vegorov-rbx vegorov-rbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has to be automated, updating manually on each release is not an option.

@Ketasaja Ketasaja marked this pull request as draft July 31, 2024 19:01
@Ketasaja Ketasaja marked this pull request as ready for review July 31, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Include version in CLI output
4 participants