Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possibility to trigger assert when looping through Intersection Types #1393

Closed
wants to merge 1 commit into from

Conversation

karl-police
Copy link
Contributor

@karl-police karl-police commented Sep 11, 2024

#1391

I don't know but adding id = follow(id) fixed the issue and when I compared the entryMap size with and without the intersection, the output was the same.

Though now regarding the Unit Test from that issue post, it's a modified version for the unit test for this one #1392

@aatxe
Copy link
Collaborator

aatxe commented Sep 13, 2024

Thanks for the PR. We've implemented this internally, and it'll be in the next release, but we chose it (since it's very minor) as the basis for introducing our versioning flag for the new solver. So, I'll close out this issue, but the 644 release will come with a flagged version of this additional follow.

@aatxe aatxe closed this Sep 13, 2024
@karl-police karl-police deleted the patch-1 branch September 15, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants