Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: If statement initializers #23
base: master
Are you sure you want to change the base?
RFC: If statement initializers #23
Changes from 1 commit
49644ab
8ecc5cf
7615e25
33a5933
927dfed
32fd23e
08ce8e2
fad18b4
614a6c2
b4e09af
548d4c8
544f99e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to add that this design point is one we have to live with in perpetuity. If we decided to take this fallthrough semantics out of this RFC, then we're stuck with that behavior.
Using
boolean
is an ok example, but it doesn't strongly argue for it as opposed to some other example I posted earlier wrtanimal
and one that @vegorov-rbx posted withpcall
example. If a design point is a "choose now or forever hold your peace," it especially needs an equally as compelling argument to support it.So I'd rather block the RFC until we are able to agree on this design point, whether locals should fallthrough or not.
An example where the behavior is breaking change would also be good to include in the alternatives section.
As is, this RFC proposes the
print(x)
in theelse
branch to print any odd numbers.