RFC: Negation types #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatxe
reviewed
May 8, 2024
aatxe
reviewed
May 8, 2024
aatxe
reviewed
May 8, 2024
Co-authored-by: aaron <[email protected]>
Co-authored-by: aaron <[email protected]>
aatxe
reviewed
May 8, 2024
Comment on lines
+72
to
+74
| We can use type families to have this guarantee. Add a `negate<T>` type family which would be internal to the type inference engine, and have the syntax `~T` produce that type family, not a `NegationType`. | ||
|
|
||
| As for the type error, we can just consider `negate<{ p: P }>` to be an uninhabited type family, and resolve that as an error type. |
There was a problem hiding this comment.
I think this is very sensible, and aligned with where future proposals will go too (e.g. type indexing syntax like SomeTableType.SomeProperty will probably want to resolve to index<SomeTableType, SomeProperty>). Seems like the right call to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered.