Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Stable Sort #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

RFC: Stable Sort #41

wants to merge 7 commits into from

Conversation

dubiousjim
Copy link

@dubiousjim dubiousjim commented Jun 10, 2024 •
edited
Loading

This RFC proposes introducing a stable sorting algorithm to the table library. The particular algorithm proposed is "Block Merge Sort."

Rendered

@dubiousjim
RFC: Stable Sort
8f4646c 
This RFC proposes introducing a stable sorting algorithm to the table
library. The particular algorithm proposed is "Block Merge Sort."
ccuser44
ccuser44 reviewed Nov 9, 2024
View reviewed changes
Copy link

@ccuser44 ccuser44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A potential problem though is that the semantics of table.sort are unclear and the validity of table.stablesort existing depends on that. I agree though that the sorting mechanisms of table.sort can be somewhat problematic in some scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegorov-rbx vegorov-rbx vegorov-rbx left review comments

@ccuser44 ccuser44 ccuser44 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@vegorov-rbx vegorov-rbx

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dubiousjim @ccuser44 @vegorov-rbx