Android / Blur Transformation: Fix leaked RenderScript objects #1562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Manually invoke
Destroy()
on allocated RenderScript objects within the (Android)BlurTransformation
class. Previously the assumption was that .NETDispose()
would call this for us, but this does not seem to be the case.By not doing this, the Android runtime complains about leaked resources.
Note: Also removed a duplicated copy of the Blur code that was commented out. Happy to revert this change if required.
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
'StrictMode' was enabled by inserting the following to activity
OnCreate
📝 Links to relevant issues/docs
🤔 Checklist before submitting