Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Changed the season definition when using isSeasonTiedWithSystemTime to be more realistic #213

Open
wants to merge 1 commit into
base: 1.20
Choose a base branch
from

Conversation

jaoreir
Copy link

@jaoreir jaoreir commented Dec 3, 2024

Why the change

I like when games sync the seasons to real life, so I enabled the config option isSeasonTiedWithSystemTime, but I find it strange that winter starts on the end of December, instead of somewhere near the start.
So I changed the definition of seasons when using that option to be more realistic.

Original definition

Northern Hemisphere

  • Spring: 3/20 ~ 6/20
  • Summer: 6/21 ~ 9/21
  • Fall: 9/22 ~ 12/20
  • Winter: 12/21 ~ 3/19

Southern Hemisphere

  • Spring: 9/22 ~ 12/20
  • Summer: 12/21 ~ 3/19
  • Fall: 3/20 ~ 6/20
  • Winter: 6/21 ~ 9/21

New definition

In the north, spring is slightly longer, and fall is slightly shorter because of the earth's elliptical orbit.
(The specific dates were adapted from other games.)

Northern Hemisphere

  • Spring: 2/25 ~ 5/31
  • Summer: 6/1 ~ 8/31
  • Fall: 9/1 ~ 11/25
  • Winter: 11/26 ~ 2/24

Southern Hemisphere

  • Spring: 8/25 ~ 11/30
  • Summer: 12/1 ~ 2/28
  • Fall: 3/1 ~ 5/25
  • Winter: 5/26 ~ 8/24

@lucaargolo
Copy link
Owner

lucaargolo commented Dec 8, 2024

I like these changes. I'll probably add another config option so you can choose between the new definition and the old one.
As soon as I have time, I'll review and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants