Fixes comparator output on Fluid Hoppers

lucaargolo · Oct 9, 2022 · 5ee52f3 · 5ee52f3
1 parent 74575d0
commit 5ee52f3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/main/kotlin/io/github/lucaargolo/kibe/blocks/miscellaneous/FluidHopper.kt b/src/main/kotlin/io/github/lucaargolo/kibe/blocks/miscellaneous/FluidHopper.kt
@@ -44,7 +44,7 @@ class FluidHopper: HopperBlock(FabricBlockSettings.of(Material.METAL, MapColor.S
     override fun hasComparatorOutput(state: BlockState?) = true
 
     override fun getComparatorOutput(state: BlockState?, world: World, pos: BlockPos): Int {
-        return StorageUtil.calculateComparatorOutput((world.getBlockEntity(pos) as? TankBlockEntity)?.tank)
+        return StorageUtil.calculateComparatorOutput((world.getBlockEntity(pos) as? FluidHopperBlockEntity)?.tank)
     }
 
     override fun onUse(

diff --git a/src/main/kotlin/io/github/lucaargolo/kibe/blocks/miscellaneous/FluidHopperBlockEntity.kt b/src/main/kotlin/io/github/lucaargolo/kibe/blocks/miscellaneous/FluidHopperBlockEntity.kt
@@ -3,6 +3,7 @@
 package io.github.lucaargolo.kibe.blocks.miscellaneous
 
 import io.github.lucaargolo.kibe.blocks.getEntityType
+import io.github.lucaargolo.kibe.utils.SyncableBlockEntity
 import io.github.lucaargolo.kibe.utils.readTank
 import io.github.lucaargolo.kibe.utils.writeTank
 import net.fabricmc.fabric.api.lookup.v1.block.BlockApiCache
@@ -23,7 +24,7 @@ import net.minecraft.util.math.Direction
 import net.minecraft.world.World
 import kotlin.math.min
 
-class FluidHopperBlockEntity(block: FluidHopper, pos: BlockPos, state: BlockState): BlockEntity(getEntityType(block), pos, state) {
+class FluidHopperBlockEntity(block: FluidHopper, pos: BlockPos, state: BlockState): SyncableBlockEntity(getEntityType(block), pos, state) {
 
     companion object {
         private const val CAPACITY = FluidConstants.BUCKET
@@ -44,6 +45,16 @@ class FluidHopperBlockEntity(block: FluidHopper, pos: BlockPos, state: BlockStat
     val tank = object : SingleVariantStorage<FluidVariant>() {
         override fun getBlankVariant(): FluidVariant = FluidVariant.blank()
         override fun getCapacity(variant: FluidVariant?): Long = CAPACITY
+
+        override fun onFinalCommit() {
+            markDirtyAndSync()
+        }
+    }
+
+    fun markDirtyAndSync() {
+        markDirty()
+        if(world?.isClient == false)
+            sync()
     }
 
     override fun writeNbt(tag: NbtCompound) {
@@ -56,6 +67,10 @@ class FluidHopperBlockEntity(block: FluidHopper, pos: BlockPos, state: BlockStat
         readTank(tag, tank)
     }
 
+    override fun writeClientNbt(tag: NbtCompound) = tag.also { writeNbt(it) }
+
+    override fun readClientNbt(tag: NbtCompound) = readNbt(tag)
+
     private fun tick(world: ServerWorld, pos: BlockPos, state: BlockState) {
         if (!state[HopperBlock.ENABLED]) return