Feature: Adds drink XP feature #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaique-lisboa
commented
Sep 26, 2023
Comment on lines
+48
to
+63
| transaction.addCloseCallback { _, result -> | ||
| if(result.wasAborted()) { | ||
| return@addCloseCallback | ||
| } | ||
| player.addExperience(convertMilibucketsToXp(liquidXpToExtract).toInt()) | ||
| if(extractedAmount > 0) { | ||
| player.world.playSound( | ||
| null, | ||
| player.blockPos, | ||
| SoundEvents.ENTITY_EXPERIENCE_ORB_PICKUP, | ||
| SoundCategory.AMBIENT, | ||
| .5f, | ||
| player.world.random.nextBetween(3,9).toFloat() / 10) | ||
| } | ||
| } | ||
| transaction.commit() |
There was a problem hiding this comment.
very important step, validating on transaction success ensures that the XP was actually drained from tank before adding the experience levels to player.
XpDrain and XpShowerBlockEntity should use wasAborted or wasCommited methods of Transaction as well, as of today, if the fluid transfer fails for whatever reason, the XP will be drained / created either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likewise it was in OpenBlocks the player could be able to consume the Liquid XP from the tanks by right-clicking into it.
This feature would help player to easily achieve the desired level for enchanting and other applications.