Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two rendering issues caused by mod interoperability #230

Open
wants to merge 2 commits into
base: 1.20
Choose a base branch
from

Conversation

val-int1
Copy link

This PR fixes two rendering related issues caused by using Kibe with other mods I found:

  • The first one causes tank item models to be invisible (this happens when other mods wrap the tank model in another class, for example Continuity, though it requires that other class to be implementing the WrapperBakedModel interface from Fabric API). While this isn't game breaking or causing crashes, it can still be annoying when the tanks are empty.
  • The second one causes a crash when looking at an entangled chest/tank through an Immersive Portals portal, while the crosshair is looking outside of the portal (it might also need the portal to be in another dimension), as IP gives a null crosshair target (which then causes issues with the MinecraftClient.getInstance().crosshairTarget!! parts).

It happens when another mod wraps the tank model into another class (example: Continuity)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant