Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve lint-staged with jest and prettier #35

Merged
merged 1 commit into from
May 9, 2020

Conversation

Cleysonlb
Copy link
Collaborator

Improve lint-staged with:

  • jest
  • prettier

Why?

  • with jest you guarantee that you will not commit with broken tests
  • with the prettier ensures that the code will be formatted at commit time

lint-staged now

{
    "src/**/*.{ts,js}": [
        "eslint --fix",
        "jest",
        "prettier --check --write 'src/**/*.{ts,js}'",
        "git add"
    ]
}

Copy link
Collaborator

@omurilo omurilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I think formatting with prettier is more for nutella developer (#brinks, I don't do anything without prettier and when I format it in my hand as if it were kkkk).

@Cleysonlb
Copy link
Collaborator Author

Why build is broken?
##[error]Resource not accessible by integration
@lucasmontano or @omurilo give me a little help 😄 hahah

@omurilo
Copy link
Collaborator

omurilo commented May 6, 2020

Why build is broken?
##[error]Resource not accessible by integration
@lucasmontano or @omurilo give me a little help 😄 hahah

@Cleysonlb this build is broken by a bug in greetings action of github actions, this bug it be described in actions/first-interaction#10

@Cleysonlb
Copy link
Collaborator Author

Thanks @omurilo! more one approve can i merge?

@omurilo omurilo merged commit 223b256 into lucasmontano:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants