Skip to content
This repository was archived by the owner on May 27, 2019. It is now read-only.

Many improvements #5

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Many improvements #5

wants to merge 31 commits into from

Conversation

arjan
Copy link
Contributor

@arjan arjan commented Feb 11, 2014

This branch supports OAuth, reconnecting behaviour, configurability of the Endpoint URL (both GET and POST).

Furthermore it prefixes the modules with twerl_ to comply with common Erlang coding guidelines.

@arjan
Copy link
Contributor Author

arjan commented Feb 11, 2014

Hmm, no idea how your own commits became part of this PR..

@lucaspiller
Copy link
Owner

Awesome, thanks! I'll take a look over the next couple of days - bug me if I haven't in a week!

On Wed, Feb 12, 2014 at 12:21 am, Arjan Scherpenisse <[email protected]="mailto:[email protected]">> wrote:

Hmm, no idea how your own commits became part of this PR..


Reply to this email directly or view it on GitHub.

@arjan
Copy link
Contributor Author

arjan commented May 26, 2014

@lucaspiller here's me bugging you ;)

@lucaspiller
Copy link
Owner

Haha thanks :D I'll try and remember to look at it this week.

If you have a chance would you mind figuring out why Travis is broken? (I think it's using the wrong version of Erlang or something)

@arjan
Copy link
Contributor Author

arjan commented May 27, 2014

Yeah, sorry about that :p I'll check it out..

@arjan
Copy link
Contributor Author

arjan commented May 27, 2014

seems the espec binary that is in the repo should be built against R14.. weird, because I did not touch that at all.

@lucaspiller
Copy link
Owner

Ok I had a quick look this morning (I also fixed the espec issues myself in master). I want to add a few more tests and examples before I merge this, so I'll take a look at that after work.

@lucaspiller lucaspiller mentioned this pull request Jun 4, 2014
2 tasks
@arjan
Copy link
Contributor Author

arjan commented Jun 10, 2014

I see you're integrating part of this, cool :)
Sorry it's such a big branch.

@arjan
Copy link
Contributor Author

arjan commented Jul 13, 2014

This last commit is quite essential -- otherwise the httpc connection is kept open after the twerl_stream process terminates. This causes issues if you want to do a new streaming connection (e.g. changed filtering parameters); the new connection to Twitter will be established but no tweets will arrive.

Arjan Scherpenisse added 2 commits July 13, 2014 22:47
(cherry picked from commit b568f5a)

Conflicts:
	src/twerl_stream_manager.erl
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants