feat: Support for times without leading '0' #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web interface of clockify supports times in format HMM (1 digit for the hour and 2 digits for the minutes), for example 915 is 09:15.
aVolpe
force-pushed
the
feat/more_time_formats
branch
from
de40480 to
3c7b94d
Compare
lucassabreu
reviewed
Dec 6, 2023
There was a problem hiding this comment.
the code looks right @aVolpe , just run go fmt pkg/timehlp/time.go pkg/timehlp/time_test.go to fix some linting issues.
|
thanks @lucassabreu , nothing was changed nor reported by that command:
(The first version of this pr has some lint errors that were reported by DeepSource, but those were fixed in a force push). |
|
i guess i saw it before the force-push. |
|
thank you for the contribution, is at the release v0.46.0 now |
I downloaded the version through homebrew and everything works! Thanks for the CLI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web interface of clockify supports times in format
HMM(1 digit for the hour and 2 digits for the minutes), for example915is09:15.I am not very familiar with go, but I added a test (following another test in this repo) to make sure everything works.
To check the new test use
go test -v pkg/timehlp/time_test.go.The parser now also supports the format
H:MMalso is supported by the web interface, to keep the names short the suffix 'WL' was used (without leading 0, suggestions welcome!).