Remove S3 & Glacier Service Name Dependencies #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might be better off deprecating the S3 and glacier calls. Then just adding your new build method so it isn't a breaking change. |
|
@bfkelsey oh you're right. I forgot compatibility you mentioned. I'll make new commit for this. thanks. anyway really thanks you guy to make v4 signer. I was able to connect to API by using your library. |
|
I'm OK with deprecating the s3 and glacier methods and moving to a generic builder method that allows you to pass in a |
|
@lucasweb78 @bfkelsey I made a new commit. please check my submit. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-v4-signer can be used for not only S3, Glacier but also other AWS services. So I removed some logics which are too dependent on S3 & Glacier service names and updated some examples & test cases.