Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): adds barrel icon #1955

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(icons): adds barrel icon #1955

wants to merge 5 commits into from

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • New Icon

Description

Icon use case

  • to indicate drinks, especially alcoholic drinks usually aged in barrels (wine, beer, whiskey)
  • to symbolise breweries/distilleries in map apps

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Added or changed icons

icons/barrel.svg

Preview cohesion icons/rotate-cw-square.svg
icons/barrel.svg
icons/radius.svg
Preview stroke widths icons/barrel.svg
icons/barrel.svg
icons/barrel.svg
DPI Preview (24px) icons/barrel.svg
Icon X-rays icons/barrel.svg
Icon Diffs icons/barrel.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BarrelIcon = createLucideIcon('Barrel', [
  ["path",{"d":"M16 20.5v-17"}],
  ["path",{"d":"M8 3.5v17"}],
  ["path",{"d":"M2 10a50.5 50.5 0 0 1 20 0"}],
  ["path",{"d":"M2 14a50.5 50.5 0 0 0 20 0"}],
  ["path",{"d":"M21.16 5.677A17 17 0 0 0 12 3a17 17 0 0 0-9.16 2.677A2 2 0 0 0 2 7.268v9.464a2 2 0 0 0 .84 1.591A17 17 0 0 0 12 21a17 17 0 0 0 9.16-2.677 2 2 0 0 0 .84-1.591V7.268a2 2 0 0 0-.84-1.591"}]
])

@jguddas
Copy link
Member

jguddas commented Mar 8, 2024

Feels more like a skewed table than a barrel to me.

@ericfennis
Copy link
Member

I don't see the barrel as well. Maybe something based on the database icon?

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Mar 8, 2024

I don't see the barrel as well. Maybe something based on the database icon?

It's a wine barrel, not an oil one.

I've tried an isometric view but it's super icky:
image

@jguddas
Copy link
Member

jguddas commented Mar 8, 2024

I don't see the barrel as well. Maybe something based on the database icon?

It's a wine barrel, not an oil one.

I've tried an isometric view but it's super icky: image

The isometric one looks cute and barrely.

@karsa-mistmere
Copy link
Member Author

I don't see the barrel as well. Maybe something based on the database icon?

It's a wine barrel, not an oil one.
I've tried an isometric view but it's super icky: image

The isometric one looks cute and barrely.

It looks like a hand grenade.

@ericfennis
Copy link
Member

ericfennis commented Apr 5, 2024

Maybe giving it a tap and some feet can help?
image

Another icon:
https://www.iconfinder.com/icons/5380899/barrel_drum_faucet_tap_water_icon

@github-actions github-actions bot added the Stale label May 9, 2024
@ericfennis
Copy link
Member

@karsa-mistmere What about this design?

image

@ericfennis ericfennis removed the Stale label Jun 14, 2024
@lucide-icons lucide-icons deleted a comment from github-actions bot Jun 14, 2024
@karsa-mistmere
Copy link
Member Author

@karsa-mistmere What about this design?

image

I explored something similar but it's just too dense this way.

@ericfennis
Copy link
Member

I think it is not that bad

@karsa-mistmere
Copy link
Member Author

I think it is not that bad

Well, in practice the corners do not fulfil the 2px gap rule, I'm afraid. 😅

@ericfennis
Copy link
Member

Hmm true, this is also an option, but looks denser
image

@karsa-mistmere
Copy link
Member Author

Hmm true, this is also an option, but looks denser image

In this case, it's the central segments of each side that do not have sufficient gaps. :/

@jguddas
Copy link
Member

jguddas commented Jun 14, 2024

Hmm true, this is also an option, but looks denser image

Still no joy to be sparked :/

@github-actions github-actions bot added the Stale label Aug 4, 2024
@jguddas
Copy link
Member

jguddas commented Nov 9, 2024

Do you still have that isomorphic view flying around somewhere?

@lucide-icons lucide-icons deleted a comment from github-actions bot Nov 15, 2024
@ericfennis ericfennis removed the Stale label Nov 15, 2024
@jamiemlaw
Copy link
Contributor

Maybe moving the rings around the barrel more towards the edges helps? And add a tap for good measure. Or still too dense?

image

icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Nov 15, 2024

Maybe moving the rings around the barrel more towards the edges helps? And add a tap for good measure. Or still too dense?

image

iconsOpen lucide studio

Even without the tap, your version looks quite barrel-y.

icons
Open lucide studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants