feat(*): add ERC20 standard #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoloshko
reviewed
Mar 6, 2019
migrations/deployers/Salable.js
Outdated
| 'address', | ||
| 'uint256', | ||
| 'string', | ||
| 'uint8', |
There was a problem hiding this comment.
this is already present in Sales contract, this is nice feature that might help us to automatically deploy contract... that's why I kept it.
migrations/deployers/Salable.js
Outdated
| wallet, | ||
| config['total'], | ||
| config['name'], | ||
| config['decimals'], |
There was a problem hiding this comment.
same as #5 (comment)
Add `Salable` contract that uses ERC20 token standard. LIT-195
- unit tests for `Salable` contract - change a way how configuration is stored - deployer script that can be used outside repository - add changelog LIT-195
DZariusz
force-pushed
the
feature/lit-195-salable-rc20
branch
from
b5959c2
to
9225862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Salablecontract that uses ERC20 token standard.Salable.solcontract has same top interface asSales.solbut insteadHumanStandardTokenit uses open sourceERC20standard. This contract can be used as standalone (same asSales) and it can be used byStakingBankto manage staking tokens, which is basically a reason why we needSalablein in a first place.LIT-195