Skip to content

Commit

Permalink
release the final fix for issue with text conditionining on first few…
Browse files Browse the repository at this point in the history
… tokens
  • Loading branch information
lucidrains committed May 16, 2024
1 parent 08b914d commit eb2ce45
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Please join <a href="https://discord.gg/xBPBXfcFHd"><img alt="Join us on Discord

- <a href="https://github.com/MarcusLoppe">Marcus</a> yet again for running the experiments to validate that it is possible to extend the system from triangles to <a href="https://github.com/lucidrains/meshgpt-pytorch/issues/54#issuecomment-1906789076">quads</a>

- <a href="https://github.com/MarcusLoppe">Marcus</a> for identifying <a href="https://github.com/lucidrains/meshgpt-pytorch/issues/80">an issue</a> with text conditioning and for running all the experiments that led to it being resolved

## Install

```bash
Expand Down
3 changes: 2 additions & 1 deletion meshgpt_pytorch/meshgpt_pytorch.py
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,7 @@ def __init__(
fine_attn_dim_head = 32,
fine_attn_heads = 8,
pad_id = -1,
num_sos_tokens = 1,
num_sos_tokens = None,
condition_on_text = False,
text_condition_model_types = ('t5',),
text_condition_cond_drop_prob = 0.25,
Expand All @@ -1062,6 +1062,7 @@ def __init__(
# the fine transformer sos token
# as well as a projection of pooled text embeddings to condition it

num_sos_tokens = default(num_sos_tokens, 1 if not condition_on_text else 4)
assert num_sos_tokens > 0

self.num_sos_tokens = num_sos_tokens
Expand Down
2 changes: 1 addition & 1 deletion meshgpt_pytorch/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '1.2.6'
__version__ = '1.2.7'

0 comments on commit eb2ce45

Please sign in to comment.