Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perDocument port and back-button workaround #53

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

perDocument port and back-button workaround #53

wants to merge 1 commit into from

Conversation

andrewshumway
Copy link

port of perdoument changes from searchHub. Attempt fix for back-button

For comparison. Delete after review

@gsingers
Copy link
Contributor

@andrewshumway Can you separate out the perDoc work from all of the other stuff? Also, you have things like ~ files checked in.

@andrewshumway
Copy link
Author

I submitted this in response to some Q&A we had regarding back-button functionality. I had a work-around for problems but have doubts about the approach. You wanted to see the code and asked for a pull request. I never thought this would be merged up and so left the template code so as to give a complete picture.

If you think the back-button approach I'm using here has more merit than reworking all of this to use a $state or some sort of $route functionality where back-button behavior is baked in then I can re-submit with the template code removed. However, I've identified a couple of problems already with what's here in this pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants