chore: start to clean kubeinvaders.js #87
Conversation
|
|
||
| return prefix + suffix; | ||
| } | ||
|
|
||
| var codename = getCodeName(); |
There was a problem hiding this comment.
Co-located getCodeName near to where is used.
| async function checkHTTP(url, elementId) { | ||
| const response = await fetch(url); | ||
| $("#" + elementId).val(response.status); | ||
| } |
There was a problem hiding this comment.
Simplified checkHTTP using fetch --> https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API
| Object.keys(queryParams).forEach(key => url.searchParams.set(key, queryParams[key])); | ||
| } | ||
|
|
||
| return fetch(url); | ||
| } |
There was a problem hiding this comment.
Created this helper function to reduce the code needed to send GET requests to k8s_url
| for (var i = 0;i < lines.length;i++){ | ||
| metric = lines[i].split(' '); | ||
| async function getMetrics() { | ||
| const response = await httpGetToK8S("/metrics"); |
There was a problem hiding this comment.
Switched from XMLHttpRequest to httpGetToK8S
There was a problem hiding this comment.
Also used async/await to not rely on callbacks and make the code seamless syncronous.
| const text = await response.text(); | ||
|
|
||
| for (const line of text.split('\n')) { | ||
| const [key, value] = line.split(' '); |
There was a problem hiding this comment.
Switched from:
var lines = this.responseText.split('\n');
for (var i = 0;i < lines.length;i++){
metric = lines[i].split(' ');
Also I'm using the deconstructing assignement to give a name to the key/value pair
|
Ah, someone else already completed the task! Closing in favour of #88 |
|
hi @gdorsi ok thank you! |
Part of #82