Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ARM runners #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LesnyRumcajs
Copy link

Sample run: https://github.com/LesnyRumcajs/action-shellcheck/actions/runs/13140996529

Adds support for ARM-based runners.

Closes #112

@bwhitehead0
Copy link

Even though arm runners are super common, you're probably better off forking the repo and adding support for ARM there.

@LesnyRumcajs
Copy link
Author

Even though arm runners are super common, you're probably better off forking the repo and adding support for ARM there.

Could you please elaborate why this would be a better solution? Different architecture is already supported by the upstream tool. I'd find it confusing if I had to use different actions for different runners.

@bwhitehead0
Copy link

The maintainer has zero interest in adding ARM support last I and others checked, unfortunately.

@LesnyRumcajs
Copy link
Author

@ludeeus Would you like make things easier for others and add support for ARM runners? Seems it'd be appreciated by the general community, especially since ARM runners will likely become the standard, given their benefits over AMD ones.

@ludeeus
Copy link
Owner

ludeeus commented Feb 5, 2025

The maintainer has zero interest in adding ARM support last I and others checked, unfortunately.

Where did i say that?

@ludeeus
Copy link
Owner

ludeeus commented Feb 5, 2025

@ludeeus Would you like make things easier for others and add support for ARM runners? Seems it'd be appreciated by the general community, especially since ARM runners will likely become the standard, given their benefits over AMD ones.

Once github hosted runners are out of preview, this can be added.

@LesnyRumcajs
Copy link
Author

Once github hosted runners are out of preview, this can be added.

That seems reasonable; thanks for the quick reply. I'll ping you once this happens. Cheers.

@bwhitehead0
Copy link

The maintainer has zero interest in adding ARM support last I and others checked, unfortunately.

Where did i say that?

In the PR I submitted a year or two back.

Private/custom runners have supported ARM for a long time. Enterprises use them a lot.

@ludeeus
Copy link
Owner

ludeeus commented Feb 5, 2025

For completeness that PR points to this comment:

Untill GitHub provide action runners for it, this is not sometthing I will add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ARM workers
3 participants