fix(config): add Windows home dir path #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludviglundgren
changed the title
ludviglundgren
requested changes
Jan 23, 2024
On PowerShell / CMD the HOME environment variable is often not defined, so $HOME/.config/qbt will evaluate to C:/.config/qbt instead of C:/<username>/.config/qbt as one would expect.
Acamol
force-pushed
the
fix-windows-config
branch
from
3039703 to
bc5431d
Compare
|
Hey @Acamol , sorry for this taking so long to get back to. I made a change to use the built in filepath.join to build the path which should make it use the correct separator for the environment. On Windows that's backslash Could you try this out and report back and if it's ok? Then we can merge this and get a new release out. |
|
It seems to be working fine on my system with your change. |
ludviglundgren
approved these changes
Aug 19, 2024
|
Sorry about the delay, will get this merged and some other PRs and then make a new release 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PowerShell / CMD the HOME environment variable is often not defined, so $HOME/.config/qbt will evaluate to C:/.config/qbt instead of C:/<username>/.config/qbt as one would expect.