Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullability annotations #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcantrell
Copy link

This adds annotations necessary for normal usage on Swift 3. Without these, code must deal with null values that Nocilla never actually returns, i.e. lots of ? interspersed in Nocilla DSL calls.

I haven’t been able to find an Obj-C annotation that gets rid of unused value warnings for the returned function pointers Nocilla uses. In Swift 3, it’s necessary to do this:

_ = stubRequest(...)

@pcantrell
Copy link
Author

Hmm, looks like this only compiles under Xcode 8. This can certainly wait for it to go GM.

@stephengazzard
Copy link

stephengazzard commented Oct 26, 2016

Thanks for doing this @pcantrell . We recently updated our tests to Swift3, I forked off this branch for any Swift 3 related changes we'd end up needing to make, and you pretty much caught everything that was hitting us with this. I only ended up making one change:

RobotsAndPencils@b278fdd

Figured it might make more sense for you to change this than for me to create a separate PR which is mostly your changes.

@luisobo when do you think you would have a chance to review + merge this PR?

@andrewkboyd
Copy link
Collaborator

I'd be happy to merge this, but I would like to get the travis build passing first.

Travis - OS X CI environment
Travis - testing on multiple OSs

I'm assuming if we get it running in travis on osx_image: xcode8 things should be good. We need to add a matrix section first though. We probably want to add a matrix of OSs to run/build/test on, and since we are building for multiple platforms now, probably need to add scripts to run on the various sdks (the last part is outside the scope for this PR though)

@andrewkboyd
Copy link
Collaborator

I had just a few minutes to play around with this today and made some changes to the travis.yml file on a separate branch with your changes.

I got it working, but need to think about how to ensure that things still work across the various platforms.

@tpalmer
Copy link

tpalmer commented Aug 20, 2018

Is this still under development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants