Haptic Feedback #18
Open
Haptic Feedback #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relys
reviewed
Sep 17, 2024
| } | ||
|
|
||
| static HapticFeedbackType state_to_haptic_type(const State *state) { | ||
| if (state->state != STATE_RUNNING) { |
There was a problem hiding this comment.
You're gonna want to check if state->mode == MODE_FLYWHEEL so duty cycle haptics don't happen in flywheel mode.
There was a problem hiding this comment.
Duty SAT is not being set during Flywheel (and I tested it, it doesn't buzz for me). Not sure about the error ones right now. If they were:
- you'd supposedly want to hear them
- they'll most likely make the board fall over as they change the setpoint
There was a problem hiding this comment.
Sounds good. Only reason I mention is because it was in the original float package.
lukash
force-pushed
the
feature/haptic-feedback
branch
from
b568ec2 to
d6b751f
Compare
Feature: Implement Haptic Feedback
lukash
force-pushed
the
feature/haptic-feedback
branch
from
65298ce to
d475f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative PR to #12. I believe this implementation is better structured and simpler.
The PR is not meant to be merged as-is, it's posted to allow for submitting feedback. It will be made available in a release as a feature preview and after gathering feedback on the feature we should reduce the number of config options.