Improvements to LED Help texts #31
Conversation
I tried to clarify a few things that confused me or that seemed counter-intuitive. Also removed the (redundant) explanation of the different white LED alternatives for secondary colors.
| <ul style="margin-top: 0px; margin-bottom: 0px; margin-left: 0px; margin-right: 0px; -qt-list-indent: 1;"><li style="" style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">White (full) is full brightness on all four channels, the brightest it can be. It also consumes the most power. On RGB LEDs, this is the same as White (rgb).</li> | ||
| <li style="" style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">White (rgb) is the white of the three RGB channels.</li> | ||
| <li style="" style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">White (single) only works on RGBW and is the single white channel. It's black on RGB-only LEDs. Less bright than White (full), but consumes significantly less power.</li></ul></body></html></description> | ||
| <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">Front secondary color. Only used by a few of the fancy lighting modes.</li></ul></body></html></description> |
There was a problem hiding this comment.
I disagree with "Only used by a few of the fancy lighting modes." a lot of them actually use it. Basically all of them besides "Solid" and the rainbow modes. What about this if the goal is to make succinct:
Front secondary color for most animated modes.
| @@ -2696,7 +2691,7 @@ p, li { white-space: pre-wrap; } | |||
| <html><head><meta name="qrichtext" content="1" /><style type="text/css"> | |||
| p, li { white-space: pre-wrap; } | |||
| </style></head><body style=" font-family:'Roboto'; ; font-weight:400; font-style:normal;"> | |||
| <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">Front animation speed.</p></body></html></description> | |||
| <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">Front animation speed. Higher numbers make it slower.</p></body></html></description> | |||
There was a problem hiding this comment.
Not true. You scared me a bit if this was true it'd be pretty confusing. If you've found a mode for which it makes it slower, it's a bug.
| @@ -3266,7 +3246,7 @@ p, li { white-space: pre-wrap; } | |||
| <html><head><meta name="qrichtext" content="1" /><style type="text/css"> | |||
| p, li { white-space: pre-wrap; } | |||
| </style></head><body style=" font-family:'Roboto'; ; font-weight:400; font-style:normal;"> | |||
| <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">Duty threshold at which the duty is shown on the status bar instead of the battery. Note there is a 10% hysteresis, meaning if you duty shows at 20%, it will be shown until it drops below 10% (to avoid constant blinking). Values below 15% set the threshold to 15%.</p> | |||
| <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">Duty threshold above which the duty is shown on the status bar (yellow or red) instead of the battery. Note there is a 10% hysteresis, meaning if you duty shows at 20%, it will be shown until it drops below 10% (to avoid constant blinking). Values below 15% set the threshold to 15%.</p> | |||
There was a problem hiding this comment.
Not sure red needs to be mentioned. It's only the last few LEDs that are colored red if duty is that high. Red could be used for something else in the future and there could be other bars that'll have their top ends colored red (the description could obviously be tweaked then, just trying to avoid back and forth). What about:
... duty is shown on the status bar (in amber yellow color) instead of ...
|
I have no way to test LEDs for the next two weeks so I trust that you're right about the speed and I just misinterpreted what I observed. All the changes you propose make sense to me. Feel free to just make them yourself - I don't care if my name is attached to the commit |
|
Alright, pushed it here: 633bd26 (this one should have been against I also upped the default for the |
I tried to clarify a few things that confused me or that seemed counter-intuitive. Also removed the (redundant) explanation of the different white LED alternatives for secondary colors.