New brake current behavior for 6.05 firmware #7
Conversation
Compatible with 6.02 as well Signed-off-by: Dado Mista <[email protected]>
| } | ||
|
|
||
| // Use brake current over certain ERPM to prevent the board skidding to a stop when deactivated | ||
| // at speed? |
There was a problem hiding this comment.
Is the question mark in the comment intentional? It doesn't make me feel very confident 🙂
|
|
||
| // Use DC control mode as it has better holding power | ||
| // Also improves with 6.05 shorting feature | ||
| VESC_IF->mc_set_duty(0); |
There was a problem hiding this comment.
I wonder if you'd always want to do this, not just when movement was detected (on line 1046 above) and it didn't time out?
There was a problem hiding this comment.
I wonder if you'd always want to do this, not just when movement was detected (on line 1046 above) and it didn't time out?
that would be a question for the VESC Discord. My guess is that it would waste energy and drain our batteries. That's why this entire logic exists (we used to not have it and brake current was keeping our ESCs warm...)
There was a problem hiding this comment.
No response on the discord, I guess I'll do some testing when I have a chance...
|
Sorry, the comment was there before I tested it, should be removed |
Sorry about that comment. Made sense when pitching the idea to you guys. |
|
We should also change Line 1046 in 851431a
as discussed https://discordapp.com/channels/904830990319485030/1092899715273740470/1277394682166378609 |
|
I've been riding this for the last two weeks along with @lukash's Sticky Brake changes and have found it to work very well. No complaints, seems to do a great job. |
|
Thank you, closing in favor of a slightly different implementation: #22 |
Compatible with 6.02 as well