fix: repair contextQueries not working with possibly undefined values

lukemorales · Feb 25, 2024 · a7eb8d2 · a7eb8d2
1 parent 81cd141
commit a7eb8d2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/fresh-items-jam.md b/.changeset/fresh-items-jam.md
@@ -0,0 +1,5 @@
+---
+"@lukemorales/query-key-factory": patch
+---
+
+Fix `contextQueries` not working with possibly undefined values
diff --git a/src/create-query-keys.spec.ts b/src/create-query-keys.spec.ts
@@ -727,7 +727,7 @@ describe('createQueryKeys |> extrapolating "contextQueries" nesting', () => {
           contextQueries: {
             nested1: null,
             nested2: ['context-prop-2'],
-            nested3: (nestedValue: string) => ({
+            nested3: (nestedValue?: string) => ({
               queryKey: [nestedValue],
               contextQueries: {
                 nested4: null,
@@ -770,7 +770,7 @@ describe('createQueryKeys |> extrapolating "contextQueries" nesting', () => {
               _def: readonly ['test', 'prop', string, 'nested2'];
               queryKey: readonly ['test', 'prop', string, 'nested2', string];
             };
-            nested3: { _def: readonly ['test', 'prop', string, 'nested3'] } & ((nestedValue: string) => {
+            nested3: { _def: readonly ['test', 'prop', string, 'nested3'] } & ((nestedValue?: string) => {
               queryKey: readonly ['test', 'prop', string, 'nested3', string];
               _ctx: {
                 nested4: { queryKey: readonly ['test', 'prop', string, 'nested3', string, 'nested4'] };
@@ -793,10 +793,10 @@ describe('createQueryKeys |> extrapolating "contextQueries" nesting', () => {
             };
             nested3: {
               _def: readonly ['test', 'prop', string, 'nested3'];
-              queryKey: readonly ['test', 'prop', string, 'nested3', string];
+              queryKey: readonly ['test', 'prop', string, 'nested3', string | undefined];
               _ctx: {
                 nested4: {
-                  queryKey: readonly ['test', 'prop', string, 'nested3', string, 'nested4'];
+                  queryKey: readonly ['test', 'prop', string, 'nested3', string | undefined, 'nested4'];
                 };
               };
             };

diff --git a/src/types.ts b/src/types.ts
@@ -1,6 +1,6 @@
 export type AnyMutableOrReadonlyArray = any[] | readonly any[];
 
-export type Tuple = [ValidValue, ...Array<ValidValue | undefined>];
+export type Tuple = [ValidValue | undefined, ...Array<ValidValue | undefined>];
 
 export type KeyTuple = Tuple | Readonly<Tuple>;