Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1649

Merged
merged 29 commits into from
Mar 31, 2025
Merged

🌐 New Crowdin updates #1649

merged 29 commits into from
Mar 31, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Mar 29, 2025

Summary by CodeRabbit

  • Chores
    • Updated localized content by removing a navigation label displayed on the landing page in multiple languages. Users will no longer see the direct prompt for accessing the application.
    • Streamlined payment messages by removing custom wording for unknown methods in several locales, which may now fall back to default messaging.
    • Added a new sign-up prompt in English localization.

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Mar 29, 2025 3:40pm
landing ⬜️ Ignored (Inspect) Mar 29, 2025 3:40pm

Copy link
Contributor

coderabbitai bot commented Mar 29, 2025

Walkthrough

The changes remove specific key-value pairs from multiple localization JSON files. In the landing application’s localization, the "goToApp" key has been removed across several language editions, so the navigation label is no longer displayed. Additionally, in the web application’s localization, the "paymentMethodUnknown" key has been removed in select languages, affecting how unknown payment statuses are presented. There are no new features or control flow modifications.

Changes

Files Change Summary
apps/landing/public/locales/{ca,cs,da,de,es,eu,fi,fr,hr,hu,it,nl,no,pl,pt-BR,pt,ru,sk,sv,tr,zh-Hant,zh}/common.json Removed "goToApp" key, eliminating the navigation label in the UI across several languages.
apps/web/public/locales/{de,es,fi,hu,nl}/app.json Removed "paymentMethodUnknown" key, so the localized message for unknown payment methods is no longer provided.
apps/landing/public/locales/en/common.json Removed "goToApp" key and added "signUp": "Sign Up" key.
apps/web/public/locales/en/app.json Removed "paymentMethodUnknown" key, eliminating the localized string for unknown payment methods.

Possibly related PRs

  • 💄 Update landing page #1648: The changes in the main PR and the retrieved PR are related as both involve the removal of the "goToApp" key from the apps/landing/public/locales/en/common.json file.
  • 🌐 New Crowdin updates #1315: The changes in the main PR, which involve the removal of the "goToApp" key from various localization JSON files, are related to the retrieved PR as it also includes deletions of localization strings, specifically targeting the same functionality across different languages.
  • 🌐 New Crowdin updates #1491: The changes in the main PR, which involve the removal of the "goToApp" key from various localization JSON files, are related to the changes in the retrieved PR, which also involve the removal of similar keys from localization files, specifically for authentication error messages.

Poem

I'm a rabbit hopping through the code,
Skipping old keys down a winding road.
"goToApp" and unknowns out of sight,
In many tongues, making things light.
Hoppin' off with a joyous byte!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 949eda1 and 144d7fc.

📒 Files selected for processing (2)
  • apps/landing/public/locales/en/common.json (1 hunks)
  • apps/web/public/locales/en/app.json (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/web/public/locales/en/app.json
🔇 Additional comments (1)
apps/landing/public/locales/en/common.json (1)

27-28: Localization Keys Updated Consistently.
The new "signUp": "Sign Up" entry is correctly added after "meetingPoll", and the removal of the outdated "goToApp" key appears consistent with the Crowdin updates. Please ensure that the UI components consuming these keys are updated accordingly and that the changes are uniformly applied across all locale files.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lukevella lukevella merged commit 0bdceb7 into main Mar 31, 2025
5 checks passed
@lukevella lukevella deleted the l10n_main branch March 31, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant