Merge pull request #736 from lukso-network/DEV-5240

perf: remove double `_exist` check in LSP8Core
lukso-network · Oct 10, 2023 · 1b92517 · 1b92517
2 parents 624c4a6 + 49e3f6a
commit 1b92517
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/contracts/LSP8IdentifiableDigitalAsset/LSP8IdentifiableDigitalAssetCore.sol b/contracts/LSP8IdentifiableDigitalAsset/LSP8IdentifiableDigitalAssetCore.sol
@@ -285,6 +285,7 @@ abstract contract LSP8IdentifiableDigitalAssetCore is
     ) internal virtual {
         bool isRemoved = _operators[tokenId].remove(operator);
         if (!isRemoved) revert LSP8NonExistingOperator(operator, tokenId);
+
         emit RevokedOperator(
             operator,
             tokenOwner,
@@ -368,10 +369,6 @@ abstract contract LSP8IdentifiableDigitalAssetCore is
             revert LSP8CannotSendToAddressZero();
         }
 
-        if (_exists(tokenId)) {
-            revert LSP8TokenIdAlreadyMinted(tokenId);
-        }
-
         _beforeTokenTransfer(address(0), to, tokenId);
 
         // Check that `tokenId` was not minted inside the `_beforeTokenTransfer` hook