Fix solhint CI issue + use Node.js v16 in workflows (#59)

* ci: remove global `-g` flag when installing solhint

* ci: (solhint) change nodejs version to 16.x

* ci: ➕ add solhint linter to `devDependency` + run as npm script

Do not install solhint linter globally on runner during CI

* ci: 📌 use Node.js version 16.x across all workflows

.github/workflows/build-and-test.yml

@@ -13,18 +13,16 @@ jobs:
   build:
     runs-on: ubuntu-latest
 
-    strategy:
-      matrix:
-        node-version: [16.x]
-        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
-
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js ${{ matrix.node-version }}
+
+      # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+      - name: Use Node.js v16
         uses: actions/setup-node@v2
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: "16.x"
           cache: "npm"
+
       - run: npm ci
       - run: npm run build --if-present
       - run: npm run generate-types

.github/workflows/create-github-release.yml

@@ -18,11 +18,11 @@ jobs:
         uses: EndBug/version-check@v1
         id: check
 
-      - name: Use Node.js '14.16.0'
+      - name: Use Node.js v16
         if: steps.check.outputs.changed == 'true'
         uses: actions/setup-node@v2
         with:
-          node-version: "14.16.0"
+          node-version: "16.x"
           registry-url: "https://registry.npmjs.org"
           scope: "@lukso"
           cache: "npm"

.github/workflows/publish-android-artifacts.yml

@@ -18,11 +18,11 @@ jobs:
         uses: EndBug/version-check@v1
         id: check
 
-      - name: Use Node.js '14.16.0'
+      - name: Use Node.js v16
         if: steps.check.outputs.changed == 'true'
         uses: actions/setup-node@v2
         with:
-          node-version: "14.16.0"
+          node-version: "16.x"
           cache: "npm"
 
       - if: steps.check.outputs.changed == 'true'

.github/workflows/publish-ios-artifacts.yml

@@ -18,11 +18,11 @@ jobs:
         uses: EndBug/version-check@v1
         id: check
 
-      - name: Use Node.js '14.16.0'
+      - name: Use Node.js v16
         if: steps.check.outputs.changed == 'true'
         uses: actions/setup-node@v2
         with:
-          node-version: "14.16.0"
+          node-version: "16.x"
           cache: "npm"
 
       - if: steps.check.outputs.changed == 'true'

.github/workflows/publish-npm-artifact.yml

@@ -16,11 +16,11 @@ jobs:
         uses: EndBug/version-check@v1
         id: check
 
-      - name: Use Node.js '14.16.0'
+      - name: Use Node.js v16
         if: steps.check.outputs.changed == 'true'
         uses: actions/setup-node@v2
         with:
-          node-version: "14.16.0"
+          node-version: "16.x"
           registry-url: "https://registry.npmjs.org"
           scope: "@lukso"
           cache: "npm"

.github/workflows/solhint.yml

@@ -10,15 +10,13 @@ jobs:
     steps:
       - uses: actions/checkout@v2
 
-      - name: Use Node.js '14.16.0'
+      - name: Use Node.js v16
         uses: actions/setup-node@v2
         with:
-          node-version: "14.16.0"
+          node-version: "16.x"
           cache: "npm"
 
       - run: npm ci
 
-      - name: solhint
-        run: |
-          npm install -g solhint
-          solhint 'contracts/**/*.sol'
+      - name: Run Solhint Linter on Smart Contracts
+        run: npm run linter