Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add deployment info for post deployment module #708

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

skimaharvey
Copy link
Member

@skimaharvey skimaharvey commented Sep 7, 2023

What does this PR introduce?

  • Document the deployment of the UniversalProfileInitPostDeploymentModule
  • Document the deployment of the UniversalProfilePostDeploymentModule

@skimaharvey skimaharvey force-pushed the lsp23/document-deployment branch from 0eee152 to 04ff277 Compare September 7, 2023 10:36
@skimaharvey skimaharvey force-pushed the lsp23/document-deployment branch from 04ff277 to 9abf3d4 Compare September 7, 2023 10:39
@skimaharvey skimaharvey force-pushed the lsp23/document-deployment branch from 83fdf31 to 759e5f2 Compare September 8, 2023 06:58
Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest adding a README.md inside the folder contracts/LSP23LinkedContractsDeployment/module/ folder, and:

  • either put the content of both files inside this README.md file.
  • put some basic content with links from this README file to both other Markdown file

This way, when someone goes on Github here at this link: https://github.com/lukso-network/lsp-smart-contracts/tree/develop/contracts/LSP23LinkedContractsDeployment/modules

then the content will appear.

@skimaharvey skimaharvey force-pushed the lsp23/document-deployment branch 3 times, most recently from 8bc75b2 to 89d504d Compare September 11, 2023 14:21
@skimaharvey skimaharvey force-pushed the lsp23/document-deployment branch from 89d504d to 107b894 Compare September 11, 2023 15:03
@CJ42 CJ42 merged commit bc60156 into develop Sep 12, 2023
@CJ42 CJ42 deleted the lsp23/document-deployment branch September 12, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants