-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update gas benchmark CI to display gas diffs as well as the figures #731
Conversation
Task linked: DEV-5903 Display Gas Diff in Gas Benchmark CI |
9a73464
to
56accfa
Compare
5232bf8
to
3a04ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
uses: actions/checkout@v3 | ||
# Do not run `git clean -ffdx && git reset --hard HEAD` to prevent removing `gas_benchmark_before.json` | ||
with: | ||
clean: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
What does this PR introduce?
📦 Build
Create new hardhat task
hardhat gas-benchmark
to generate a table with a gas diff, based on the pre-defined scenarios set in the test fileBenchmark.test.ts
.📄 Documentation
🤖 CI
Update the CI to generate the gas report by comparing the gas figures of the base vs target branch.
PR Checklist
npm run lint
&&npm run lint:solidity
(solhint)npm run format
(prettier)npm run build
npm run test