Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts configs and tests #733

Merged
merged 5 commits into from
Oct 2, 2023
Merged

fix: ts configs and tests #733

merged 5 commits into from
Oct 2, 2023

Conversation

kalote
Copy link
Contributor

@kalote kalote commented Sep 28, 2023

What does this PR introduce?

The typescript configuration was not including the tests/ folder and has some inconsistencies (exclude is useless when there is an include for example).
By fixing it, a lot of error on the tests emerged. They have been fixed too.

PR Checklist

  • Wrote Tests
  • Wrote & Generated Documentation (readme/natspec/dodoc)
  • Ran npm run lint && npm run lint:solidity (solhint)
  • Ran npm run format (prettier)
  • Ran npm run build
  • Ran npm run test

@kalote kalote requested review from b00ste, skimaharvey, CJ42 and richtera and removed request for b00ste, skimaharvey and CJ42 September 28, 2023 14:18
@kalote
Copy link
Contributor Author

kalote commented Sep 28, 2023

FYI,

Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for flagging this and resolving the Typescript types! 🙏 🚀

tsconfig.module.json Show resolved Hide resolved
@CJ42 CJ42 merged commit a977312 into develop Oct 2, 2023
25 checks passed
@CJ42 CJ42 deleted the fix/ts-issues branch October 2, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants