build!: move @lukso/lsp-smart-contracts as its own package

.github/workflows/build-lint-test.yml

@@ -5,7 +5,7 @@ name: Node.js CI - Build + Lint + Test
 on: pull_request
 
 jobs:
-  build:
+  build-lint-test:
     runs-on: ubuntu-latest
 
     steps:
@@ -22,106 +22,27 @@ jobs:
         run: npm ci
 
       - name: 🔍 Run Solidity Linter
-        run: |
-          npm run lint:solidity
-          npm run lint:turbo:solidity
+        run: npm run lint:solidity
 
       - name: 🎨 Run ESLint on JS/TS files
-        run: |
-          npm run lint
-          npm run lint:turbo
+        run: npm run lint
 
       # This will also generate the Typechain types used by the Chai tests
       - name: 🏗️ Build contract artifacts
         run: |
           npm run build
-          npm run build:turbo
           npm run build:js
-          npm run build:js:turbo
-
-      - name: 📤 cache dependencies + build
-        uses: actions/cache@v4
-        with:
-          path: |
-            artifacts
-            node_modules
-            dist
-            types
-            contracts.ts
-            packages/**/types
-            packages/**/dist
-          key: ${{ github.run_id }}
-
-      - name: 📚 generate ABI docs
-        run: npm run build:docs
-
-      - name: 🔍 check if ABI auto-generated docs need to be updated
-        run: |-
-          if [[ $(git diff --name-only) != "" ]];
-          then
-            echo "Error: Please generate ABI docs after making changes to Solidity code and Natspec comments!"
-            exit 1
-          fi
-
-      - name: 🧪 Run Turbo tests
-        run: npm run test:turbo
-
-  test-suites:
-    strategy:
-      matrix:
-        lsp:
-          [
-            "up",
-            "upinit",
-            "lsp1",
-            "lsp6",
-            "lsp6init",
-            "lsp7",
-            "lsp7init",
-            "lsp8",
-            "lsp8init",
-            "lsp9",
-            "lsp9init",
-            "lsp11",
-            "lsp11init",
-            "lsp17",
-            "lsp17extensions",
-            "lsp20",
-            "lsp20init",
-            "lsp23",
-            "reentrancy",
-            "reentrancyinit",
-            "mocks",
-          ]
-
-    runs-on: ubuntu-latest
-    needs: [build]
-    steps:
-      - uses: actions/checkout@v3
 
-      - name: 📥 restore cache
-        uses: actions/cache@v4
-        id: "build-cache"
-        with:
-          path: |
-            artifacts
-            node_modules
-            dist
-            types
-            contracts.ts
-            packages/**/types
-            packages/**/dist
-          key: ${{ github.run_id }}
-
-      - name: Use Node.js v20
-        uses: actions/setup-node@v3
-        with:
-          node-version: "20.x"
-          cache: "npm"
+      # - name: 📚 generate ABI docs
+      #   run: npm run build:docs
 
-      - name: Install dependencies
-        if: steps.build-cache.outputs.cache-hit != 'true'
-        run: npm ci
+      # - name: 🔍 check if ABI auto-generated docs need to be updated
+      #   run: |-
+      #     if [[ $(git diff --name-only) != "" ]];
+      #     then
+      #       echo "Error: Please generate ABI docs after making changes to Solidity code and Natspec comments!"
+      #       exit 1
+      #     fi
 
-      - name: 🧪 run tests
-        run: npm run test:${{ matrix.lsp }}
+      - name: 🧪 Run tests for each package
+        run: npm run test

.github/workflows/foundry-tests.yml

@@ -4,8 +4,8 @@ on:
   pull_request:
     # compare gas diff only when editing Solidity smart contract code
     paths:
-      - "contracts/**/*.sol"
-      - "tests/foundry/**/*.sol"
+      - "packages/**/*.sol"
+      - "packages/lsp-smart-contracts/tests/foundry/**/*.sol"
 
 jobs:
   foundry-tests:
@@ -24,7 +24,9 @@ jobs:
         run: npm ci
 
       - name: NPM build
-        run: npx hardhat compile
+        run: |
+          npm run build
+          npm run build:foundry
 
       - name: Run Foundry tests
         run: npm run test:foundry
@@ -34,18 +36,18 @@ jobs:
           # due to non-deterministic fuzzing (but still use pseudo-random fuzzing seeds)
           FOUNDRY_FUZZ_SEED: 0x${{ github.event.pull_request.base.sha || github.sha }}
 
-      - name: Compare gas reports
-        uses: Rubilmax/[email protected]
-        with:
-          summaryQuantile: 0.9 # only display the 10% most significant gas diffs in the summary (defaults to 20%)
-          sortCriteria: avg,max # sort diff rows by criteria
-          sortOrders: desc,asc # and directions
-        id: gas_diff
-
-      - name: Add gas diff to sticky comment
-        if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
-        uses: marocchino/sticky-pull-request-comment@v2
-        with:
-          # delete the comment in case changes no longer impact gas costs
-          delete: ${{ !steps.gas_diff.outputs.markdown }}
-          message: ${{ steps.gas_diff.outputs.markdown }}
+      # - name: Compare gas reports
+      #   uses: Rubilmax/[email protected]
+      #   with:
+      #     summaryQuantile: 0.9 # only display the 10% most significant gas diffs in the summary (defaults to 20%)
+      #     sortCriteria: avg,max # sort diff rows by criteria
+      #     sortOrders: desc,asc # and directions
+      #   id: gas_diff
+
+      # - name: Add gas diff to sticky comment
+      #   if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
+      #   uses: marocchino/sticky-pull-request-comment@v2
+      #   with:
+      #     # delete the comment in case changes no longer impact gas costs
+      #     delete: ${{ !steps.gas_diff.outputs.markdown }}
+      #     message: ${{ steps.gas_diff.outputs.markdown }}

.github/workflows/solc_version.yml

@@ -11,15 +11,18 @@ on:
       - "develop"
     # Only run when `.sol` files have been changed
     paths:
-      - "contracts/**/*.sol"
+      - "*.sol"
 
   pull_request:
     paths:
-      - "contracts/**/*.sol"
+      - "*.sol"
 
 jobs:
   solc_version:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: packages/lsp-smart-contracts
     strategy:
       matrix:
         solc: [

.gitignore

@@ -135,11 +135,10 @@ forge-cache/
 gas_benchmark.md
 
 # Exclude build output folders
-/common
-/module
-/contracts.ts
-/devdocs
-/userdocs
+/**/dist
+/**/contracts.ts
+/**/devdocs
+/**/userdocs
 
 # test temporary folder
 /.test

deploy/001_deploy_universal_profile.ts

@@ -1,6 +1,5 @@
 import { HardhatRuntimeEnvironment } from 'hardhat/types';
 import { DeployFunction } from 'hardhat-deploy/types';
-import { ethers } from 'hardhat';
 
 const deployUniversalProfile: DeployFunction = async ({
   deployments,
@@ -9,12 +8,9 @@ const deployUniversalProfile: DeployFunction = async ({
   const { deploy } = deployments;
   const { owner } = await getNamedAccounts();
 
-  const gasPrice = await ethers.provider.getGasPrice();
-
   await deploy('UniversalProfile', {
     from: owner,
     args: [owner],
-    gasPrice,
     log: true,
   });
 };

deploy/002_deploy_key_manager.ts

@@ -1,6 +1,5 @@
 import { HardhatRuntimeEnvironment } from 'hardhat/types';
 import { DeployFunction } from 'hardhat-deploy/types';
-import { ethers } from 'hardhat';
 
 const deployKeyManager: DeployFunction = async ({
   deployments,
@@ -11,12 +10,9 @@ const deployKeyManager: DeployFunction = async ({
 
   const UniversalProfile = await deployments.get('UniversalProfile');
 
-  const gasPrice = await ethers.provider.getGasPrice();
-
   await deploy('LSP6KeyManager', {
     from: owner,
     args: [UniversalProfile.address],
-    gasPrice,
     log: true,
   });
 };

deploy/003_deploy_universal_receiver_delegate.ts

@@ -1,6 +1,5 @@
 import { HardhatRuntimeEnvironment } from 'hardhat/types';
 import { DeployFunction } from 'hardhat-deploy/types';
-import { ethers } from 'hardhat';
 import { SALT } from './salt';
 
 const deployUniversalReceiverDelegateUPDeterministic: DeployFunction = async ({
@@ -10,11 +9,8 @@ const deployUniversalReceiverDelegateUPDeterministic: DeployFunction = async ({
   const { deploy } = deployments;
   const { owner: deployer } = await getNamedAccounts();
 
-  const gasPrice = await ethers.provider.getGasPrice();
-
   await deploy('LSP1UniversalReceiverDelegateUP', {
     from: deployer,
-    gasPrice,
     log: true,
     deterministicDeployment: SALT,
   });

deploy/005_deploy_universal_receiver_delegate_vault.ts

@@ -1,6 +1,5 @@
 import { HardhatRuntimeEnvironment } from 'hardhat/types';
 import { DeployFunction } from 'hardhat-deploy/types';
-import { ethers } from 'hardhat';
 import { SALT } from './salt';
 
 const deployUniversalReceiverDelegateVaultDeterministic: DeployFunction = async ({
@@ -10,11 +9,8 @@ const deployUniversalReceiverDelegateVaultDeterministic: DeployFunction = async
   const { deploy } = deployments;
   const { owner: deployer } = await getNamedAccounts();
 
-  const gasPrice = await ethers.provider.getGasPrice();
-
   await deploy('LSP1UniversalReceiverDelegateVault', {
     from: deployer,
-    gasPrice,
     log: true,
     deterministicDeployment: SALT,
   });