Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ThemeProvider): optimize rendering #4182

Merged
merged 2 commits into from
Jul 11, 2024
Merged

perf(ThemeProvider): optimize rendering #4182

merged 2 commits into from
Jul 11, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented May 21, 2024 •
edited
Loading

  • optimize ThemeProvider rendering
  • remove unused React imports

Opening App + switching Theme to wicked and then dawn:

  • Before: 19 renders & more noticeable theme flickering
renders-before.mp4
  • Now: 11 renders & less noticeable theme flickering
renders-after.mp4

@zettca zettca requested a review from a team as a code owner May 21, 2024 10:56
@zettca zettca requested review from HQFOX and MEsteves22 and removed request for a team May 21, 2024 10:56
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4182 May 21, 2024 11:01 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4182 May 21, 2024 11:01 Destroyed
@zettca zettca marked this pull request as draft May 21, 2024 13:06
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4182 May 21, 2024 18:02 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4182 May 21, 2024 18:03 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4182 July 3, 2024 13:43 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4182 July 3, 2024 13:43 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4182 July 3, 2024 17:38 Destroyed
@zettca zettca changed the title chore(ThemeProvider): optimize rendering perf(ThemeProvider): optimize rendering Jul 9, 2024
@zettca zettca marked this pull request as ready for review July 9, 2024 11:29
@github-actions github-actions bot temporarily deployed to uikit/pr-4182 July 9, 2024 11:31 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4182 July 9, 2024 11:32 Destroyed
MEsteves22
MEsteves22 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@MEsteves22 MEsteves22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@MEsteves22 MEsteves22 requested review from a team and plagoa and removed request for a team July 10, 2024 13:37
@zettca zettca merged commit 31abd4a into master Jul 11, 2024
10 checks passed
@zettca zettca deleted the fix/stuff branch July 11, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MEsteves22 MEsteves22 MEsteves22 approved these changes

@HQFOX HQFOX Awaiting requested review from HQFOX HQFOX is a code owner automatically assigned from lumada-design/imperial

@plagoa plagoa Awaiting requested review from plagoa plagoa is a code owner automatically assigned from lumada-design/imperial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zettca @MEsteves22