Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade date-fns to version 3 #541

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Upgrade date-fns to version 3 #541

merged 2 commits into from
Jan 17, 2024

Conversation

oscarotero
Copy link
Member

Description

Version 3 has some breaking changes, but only affect to Lume in how the locales are imported.
It also comes with good types and better support for Deno.

// Version 2
import gl from "npm:date-fns/locale/gl";

// Version 3
import { gl } from "npm:date-fns/locale/gl";

More info: https://blog.date-fns.org/v3-is-out/

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@oscarotero oscarotero added this to the 2.1.0 milestone Dec 24, 2023
@oscarotero oscarotero merged commit daf3c53 into main Jan 17, 2024
3 checks passed
@oscarotero oscarotero deleted the feat/upgrade-date-fns-3 branch January 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant