Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upickle #8

Closed
wants to merge 1 commit into from
Closed

Update upickle #8

wants to merge 1 commit into from

Conversation

nafg
Copy link

@nafg nafg commented Aug 20, 2024

No description provided.

@Andrapyre
Copy link
Contributor

Andrapyre commented Aug 21, 2024

@nafg , thanks for this PR. Unfortunately, the latest upickle version requires an upgrade to Scala 3.4.x (see com-lihaoyi/upickle#607). It looks like they intend to offer support for the 3.3.x line eventually, vis-a-vis com-lihaoyi/upickle#607 (comment). I would prefer to wait for them to support a Scala 3 LTS release before upgrading.

May I ask what the use case is for this? Do you have a workaround if we don't offer support for the latest upickle version?

@nafg
Copy link
Author

nafg commented Sep 2, 2024

Upgrading https://github.com/nafg/scalajs-facades/ to sbt-ci-release 1.6 is failing because of eviction errors - my build uses ujson and I already upgraded it. I guess 1.5.x didn't have a transitive dependency of upickle at all?

Workarounds include

  • Silencing the eviction error (I don't know if this would create runtime issues)
  • Downgrading my ujson version
  • Using something other than ujson for my needs

Or I could just wait -- it's not like I need to upgrade for any reason.

Any guess how long it might take?

@Andrapyre
Copy link
Contributor

No idea what the timeline is, unfortunately. I will close this PR, since it's not building with +compile. Feel free to resubmit when upickle 4.0 supports Scala 3 LTS.

@Andrapyre Andrapyre closed this Sep 5, 2024
@nafg
Copy link
Author

nafg commented Oct 1, 2024

upickle 4.0.2 is built with Scala 3.3.4

@nafg nafg mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants