Computer program cleanup #647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore message and button texts separately
…Data(), replacing ButtonListProgram.onButtonPressed()
…d SburbServerData
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/com/mraof/minestuck/blockentity/ComputerBlockEntity.java
Outdated
Show resolved
Hide resolved
| public ComputerScreen gui; | ||
| @Nullable | ||
| public PlayerIdentifier owner; | ||
| //client side only | ||
| public int ownerId; | ||
| public Hashtable<Integer, String> latestmessage = new Hashtable<>(); | ||
| public CompoundTag programData = new CompoundTag(); | ||
| private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend); |
There was a problem hiding this comment.
Variable 'latestmessage' must be private and have accessor methods.
src/main/java/com/mraof/minestuck/blockentity/ComputerBlockEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/blockentity/ComputerBlockEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/blockentity/ComputerBlockEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/blockentity/ComputerBlockEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mraof/minestuck/blockentity/ComputerBlockEntity.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/com/mraof/minestuck/blockentity/ComputerBlockEntity.java
| private Runnable guiCallback = null; | ||
|
|
||
| @Nullable | ||
| private PlayerIdentifier owner; |
There was a problem hiding this comment.
Variable 'gui' must be private and have accessor methods.
Dweblenod
reviewed
Feb 3, 2025
| { | ||
| //TODO The implementation of this class need a serious rewrite | ||
| private static final Logger LOGGER = LogManager.getLogger(); | ||
| private static final int PROGRAM_DISK_CAPACITY = 2, BLANK_DISK_CAPACITY = 2; |
There was a problem hiding this comment.
Trying to understand why there is a hard coded limit on the number of program disks. If a computer already contains a server disk and a client disk, then would it not be possible to insert a disk with a 3rd program like GristTorrent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.